[CDN] Copy changes from API version 2019-04-15 into 2019-06-15-preview. by fore5fire · Pull Request #7442 · Azure/azure-rest-api-specs

fore5fire · 2019-10-09T21:10:12Z

This change merges changes that have already been approved from the latest stable cdn.json swagger file into the preview version (2019-04-15 > 2019-06-15-preview). It also adds new functionality into cdnwebapplicationfirewall.json, but breaking changes aren't a concern because this functionality is not yet released to customers.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-10-09T21:10:15Z

In Testing, Please Ignore

[Logs] (Generated from e36eecb, Iteration 2)

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-cdn [Logs] [Instructions] [Generation PR]
- azure-mgmt-cdn-3.1.0.zip
- azure_mgmt_cdn-3.1.0-py2.py3-none-any.whl

Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

No packages generated.

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

cdn/mgmt/2015-06-01 [Logs]
cdn/mgmt/2016-04-02 [Logs]
cdn/mgmt/2016-10-02 [Logs]
cdn/mgmt/2017-04-02 [Logs]
cdn/mgmt/2017-10-12 [Logs]
cdn/mgmt/2019-04-15 [Logs] [Instructions] [Generation PR]
- cdn.mgmt.2019-04-15.zip
preview/cdn/mgmt/2019-06-15-preview [Logs] [Instructions] [Generation PR]
- preview.cdn.mgmt.2019-06-15-preview.zip

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.Cdn [Logs] [Instructions] [Generation PR]
- Microsoft.Azure.Management.Cdn.4.2.4-preview.nupkg
- Microsoft.Azure.Management.Cdn.4.2.4-preview.snupkg

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-cdn [Logs] [Instructions] [Generation PR]
- azure-arm-cdn-4.2.0.tgz

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.19.7.gem

AutorestCI · 2019-10-09T21:11:13Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8866

AutorestCI · 2019-10-09T21:12:47Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6446

azuresdkci · 2019-10-09T21:31:42Z

Can one of the admins verify this patch?

fore5fire · 2019-11-07T21:49:21Z

@sergey-shandar What do I need to do to get this merged?

sushantsingh · 2019-11-12T00:35:09Z

@sergey-shandar Can you please help review it? We are releasing this product soon and are blocked on this swagger change to release Powershell and CLi for this product.

Removed some unused fields from ActionType

sanjaiganesh · 2019-11-26T02:41:47Z

.../cdn/resource-manager/Microsoft.Cdn/preview/2019-06-15-preview/examples/WafListPolicies.json

              },
-              "cdnEndpointLinks": [
+              "endpointLinks": [
                {


Please update allt he samples with other fields as well .. TransformType

I've updated the examples with the appropriate transforms fields.

sanjaiganesh · 2019-11-26T02:43:49Z

Adding ARMSignoff..
From offline discussion:
No customers for the Preview version ..
CDN.json is from the stable version..

So, no breaking changes as such.

2019-06-15-preview. Merge updates to CDN examples from API version 2019-04-15 to 2019-06-15-preview.

fore5fire · 2019-11-26T20:43:27Z

@sergey-shandar, Arm team has signed off - What do I need to do to get this merged?

…w. (Azure#7442)

azuresdkci assigned sergey-shandar Oct 9, 2019

azuresdkci requested a review from sergey-shandar October 9, 2019 21:11

AutorestCI mentioned this pull request Oct 9, 2019

[AutoPR cdn/resource-manager] [CDN] Copy changes from API version 2019-04-15 into 2019-06-15-preview. Azure/azure-sdk-for-go#5987

Closed

fore5fire force-pushed the cdn/feature/2019-04-15-to-2019-06-15-preview branch from 6ca7750 to e36eecb Compare October 15, 2019 20:35

AutorestCI mentioned this pull request Oct 15, 2019

[AutoPR cdn/resource-manager] [CDN] Copy changes from API version 2019-04-15 into 2019-06-15-preview. Azure/azure-sdk-for-go#6042

Closed

openapi-sdkautomation bot mentioned this pull request Oct 15, 2019

[AutoPR Microsoft.Azure.Management.Cdn] [CDN] Copy changes from API version 2019-04-15 into 2019-06-15-preview. test-repo-billy/azure-sdk-for-net#323

Closed

sergey-shandar approved these changes Nov 13, 2019

View reviewed changes

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 13, 2019

Landon Smith and others added 5 commits November 20, 2019 16:57

Copy changes from CDN version 2019-04-15 into 2019-06-15-preview.

0de44da

Update ActionType

b54f02f

Removed some unused fields from ActionType

Add range for priority

42c23d8

Fix cdnwebapplicationfirewall.json syntax.

5349f52

Add transforms to CDN WAF MatchConditions

29260c8

fore5fire force-pushed the cdn/feature/2019-04-15-to-2019-06-15-preview branch from 9256356 to 9eb5ce2 Compare November 21, 2019 01:06

fore5fire force-pushed the cdn/feature/2019-04-15-to-2019-06-15-preview branch from 9eb5ce2 to f34e29f Compare November 21, 2019 18:40

Sync latest changes from CDN 2019-04-15 to 2019-06-15-preview

0539321

fore5fire force-pushed the cdn/feature/2019-04-15-to-2019-06-15-preview branch from f34e29f to 0539321 Compare November 21, 2019 21:05

Fix CDN WAF examples for updated API version 2019-06-15-preview.

f3a418f

sanjaiganesh reviewed Nov 26, 2019

View reviewed changes

sanjaiganesh removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 26, 2019

sanjaiganesh added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 26, 2019

Add transforms examples for CDN API version

c8c1844

2019-06-15-preview. Merge updates to CDN examples from API version 2019-04-15 to 2019-06-15-preview.

fore5fire force-pushed the cdn/feature/2019-04-15-to-2019-06-15-preview branch from 842b47a to c8c1844 Compare November 26, 2019 18:17

yungezz merged commit 00345ca into Azure:master Nov 28, 2019

fore5fire mentioned this pull request Dec 9, 2019

Add CDN WAF support. Azure/azure-sdk-for-net#9014

Merged

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019

[CDN] Copy changes from API version 2019-04-15 into 2019-06-15-previe…

1176b18

…w. (Azure#7442)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CDN] Copy changes from API version 2019-04-15 into 2019-06-15-preview.#7442

[CDN] Copy changes from API version 2019-04-15 into 2019-06-15-preview.#7442
yungezz merged 8 commits intoAzure:masterfrom
fore5fire:cdn/feature/2019-04-15-to-2019-06-15-preview

fore5fire commented Oct 9, 2019 •

edited

Loading

Uh oh!

openapi-sdkautomation bot commented Oct 9, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Oct 9, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Oct 9, 2019 •

edited

Loading

Uh oh!

azuresdkci commented Oct 9, 2019

Uh oh!

fore5fire commented Nov 7, 2019

Uh oh!

sushantsingh commented Nov 12, 2019

Uh oh!

sanjaiganesh Nov 26, 2019 •

edited

Loading

Uh oh!

fore5fire Nov 26, 2019

Uh oh!

sanjaiganesh commented Nov 26, 2019

Uh oh!

fore5fire commented Nov 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

fore5fire commented Oct 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Oct 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from e36eecb, Iteration 2)

Uh oh!

AutorestCI commented Oct 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Oct 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Oct 9, 2019

Uh oh!

fore5fire commented Nov 7, 2019

Uh oh!

sushantsingh commented Nov 12, 2019

Uh oh!

sanjaiganesh Nov 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fore5fire Nov 26, 2019

Choose a reason for hiding this comment

Uh oh!

sanjaiganesh commented Nov 26, 2019

Uh oh!

fore5fire commented Nov 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

fore5fire commented Oct 9, 2019 •

edited

Loading

openapi-sdkautomation bot commented Oct 9, 2019 •

edited

Loading

AutorestCI commented Oct 9, 2019 •

edited

Loading

AutorestCI commented Oct 9, 2019 •

edited

Loading

sanjaiganesh Nov 26, 2019 •

edited

Loading